This repository has been archived by the owner on Aug 1, 2021. It is now read-only.
normalizeCiphertext corrected grouping size #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous spec was inconsistent in how it tested output strings. plaintextSegments tested for output based on square size, e.g. a 26-character input resulted in output of groups of 6 with a group of 2 left over. normalizeCiphertext however always expected groups of 5. Corrected so normalizeCiphertext follows the same pattern as plaintextSegments. Also updated the example.js to match.
|
This definitely seems easier to understand. Thank you! |
kytrinyx
added a commit
that referenced
this pull request
Sep 13, 2014
normalizeCiphertext corrected grouping size
|
Happy to help. 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous spec is inconsistent in how it tests output strings.
plaintextSegmentstested for output based on square size, e.g. a 26-character input resulted in output of groups of 6 with a group of 2 left over.normalizeCiphertexthowever always expected groups of 5. Edited sonormalizeCiphertextnow follows the same pattern asplaintextSegments,which should generate less confusion for people attempting to interpret the spec.As a corollary, updated the
example.jsto match and pass spec. Also, replaced double quotes with single quotes.