better xtask run as sudo command #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banditopazzo
force-pushed
the
better_xtask_sudo_run
branch
from
a8bad3b to
5844958
Compare
banditopazzo
force-pushed
the
better_xtask_sudo_run
branch
from
5844958 to
7339659
Compare
banditopazzo
force-pushed
the
better_xtask_sudo_run
branch
from
7339659 to
28c4aed
Compare
vadorovsky
reviewed
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes more flexible the
xtaskcommand to run binaries (examples, etc..) with root privileges.It's using
sudo -Eas before, setting thetarget.<target-triple>.runnerwhen it's required.In this way we avoid a persistent runner and basically we have a clone of
cargo runcommand in case we need to pass additional flags, for example features via--features <FEATURES>on the command line.