Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewing #293 I noticed a potential issue with the signature of the function
get_container_info
.The above mentioned PR changes are the following:
The new version assumes that
char *buf
is big at leastCONTAINER_ID_MAX_BUF
using this size in bpf helpers, but this is not true just looking at the signature.The old version it's not free of issue: it takes the
size_t sz
from the caller and safely use this size in the helpers. In general this approach is fine, it's the correct way of use it but in this case we need the buffer at least of size 72. Now we rely on the documentation of the function:but I'm proposing to use a dedicated struct for the job. The struct enforces the size of the buffer and as a plus we can pack
int id_offset
with the buffer.