Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve func autodetect error message #296

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

banditopazzo
Copy link
Member

in case of errors in function probing feature_autodetect is showing a message like this:

[2024-06-18T12:43:03Z WARN  bpf_feature_autodetect::func] Function 181 in program type BPF_PROG_TYPE_KPROBE not supported: Failed to load the eBPF feature probe: 0: R1=ctx(off=0,imm=0) R10=fp0
    0: (85) call bpf_loop#181
    R2 !read_ok
    processed 1 insns (limit 1000000) max_states_per_insn 0 total_states 0 peak_states 0 mark_read 0

this pr wants to reduce the output if backtrace is not enabled limiting the warning to one line

@banditopazzo banditopazzo requested a review from vadorovsky June 18, 2024 13:09
@banditopazzo banditopazzo force-pushed the better_autodetect_func_error branch from 69e3b48 to ba2c58a Compare June 18, 2024 17:50
@banditopazzo banditopazzo force-pushed the better_autodetect_func_error branch from ba2c58a to 616e950 Compare June 18, 2024 17:52
@banditopazzo banditopazzo self-assigned this Jun 18, 2024
@banditopazzo banditopazzo added the enhancement New feature or request label Jun 18, 2024
@vadorovsky vadorovsky merged commit 541919c into main Jun 19, 2024
21 checks passed
@vadorovsky vadorovsky deleted the better_autodetect_func_error branch June 19, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants