ci: Use architest for running test suite across architectures #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadorovsky
force-pushed
the
vadorovsky/architest
branch
3 times, most recently
from
398cf61 to
c3e3016
Compare
vadorovsky
force-pushed
the
vadorovsky/architest
branch
9 times, most recently
from
44a1295 to
d0cc91f
Compare
vadorovsky
force-pushed
the
vadorovsky/architest
branch
5 times, most recently
from
6618c06 to
7f9312d
Compare
vadorovsky
force-pushed
the
vadorovsky/architest
branch
9 times, most recently
from
da7e346 to
f189880
Compare
vadorovsky
force-pushed
the
vadorovsky/architest
branch
from
26a31b4 to
f818c98
Compare
BPF verifier on many kernel version is confused about the state of register 0 (`BPF_REG_0`) when it's not explicitly set to a value which is considered safe. Therefore, always call `BPF_MOV64_IMM(BPF_REG_0, 0)` before exiting the program.
Before using `error_for_status()`, the `test` command was just carrying on with using invalid tarball data when a requested tarball was not present.
Kernel version checks are unreliable: * Features differ across architectures. * Linux distros tend to backport features to their stable/LTS kernels. Instead of relying on version, use small probes (written in eBPF assembly) to figure out what features are available.
Having this as a test is misleading, because it's always going to fail on kernels or configurations which don't support eBPF LSM. Such case should result in graceful rollback to kprobes, not in failign tests.
… objects This way is more intuitive with the new feature probing mechanism.
The already existing C probe does it well and also catches the lack of ftrace direct call.
* Add `bpf-features` crate which contains only the `BpfFeatures` struct with a static method `all_combinations`, which is then used both by `bpf-builder` (to build programs with all feature combinations) and and `bpf-common` (to pick the correct program based on detected features). * Add `bpf-feature-autodetect` crate and move feature probes there. * Add `bpf-features-macros` crate for with the `ebpf_programs_map` macro which autogenerates mapping of features to program bytes. The program bytes (for all feature sets) are still embedded in the final binary.
Don't run them in the `build` workflow.
* Remove the unnecessary check (`offset >= skb->len`). Apparently, verifier doesn't expect it. * Improve error messages.
We already have a more reliable `FEATURE_BPF_LOOP` check for that.
vadorovsky
force-pushed
the
vadorovsky/architest
branch
from
22e9e68 to
5e216d3
Compare
banditopazzo
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo xtask cross run. Use images from the architest repository.