fix(file-system-monitor): De-duplicate FileOpen alerts for containers
#239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reading files inside container, the `file_open` LSM hook gets triggered twice. Before this change, it resulted in threat alerts being issued twice in case the opened file matched a rule. The only difference which can be spotted between `struct file` instances in both calls of `file_open` is an additional bit in `file->f_flags` during the second call. When calling `cat /etc/shadow` inside container, the `f_flags` are respectively: * `131072` (`0x1000000000000000000`) * `393216` (`0x1100000000000000000`)
vadorovsky
force-pushed
the
duplicate-events
branch
from
caecd93 to
9047980
Compare
|
closed as it seems the normal behaviour |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading files inside container, the
file_openLSM hook gets triggered twice. Before this change, it resulted in threat alerts being issued twice in case the opened file matched a rule.The only difference which can be spotted between
struct fileinstances in both calls offile_openis an additional bit infile->f_flagsduring the second call.When calling
cat /etc/shadowinside container, thef_flagsare respectively:131072(0x1000000000000000000)393216(0x1100000000000000000)