Conversation
2. Adding option to specify partition at end of sbatch command 3. Adding max steps per benchmark
Codecov Report
@@ Coverage Diff @@
## develop #218 +/- ##
========================================
Coverage 11.64% 11.64%
========================================
Files 80 80
Lines 8578 8578
Branches 1278 1278
========================================
Hits 999 999
Misses 7512 7512
Partials 67 67 Continue to review full report at Codecov.
|
2. -A option wasn't being passed through in bsuite_launch
rvinaybharadwaj
suggested changes
May 19, 2022
rvinaybharadwaj
left a comment
rvinaybharadwaj
left a comment
There was a problem hiding this comment.
Did you unintentionally delete Hadrec_dir?
Contributor
Author
|
Sorry, I was switch back and forth branches. I didn't realize it was part of develop. I added it back. Maybe double check I did it right since I think it is a sub module... |
rvinaybharadwaj
approved these changes
May 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a simple add so there is a new category for short bsuite runs.