Repository navigation
test: align unit tests with Vitest 5 default mock clearing - #4090
Merged
Merged
Conversation
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
ala-n
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the temporary
clearMocks: falseconfiguration workaround and refactors unit tests that relied on shared mock call history across test cases to ensure full compatibility with Vitest 5 default behavior (clearMocks: true).Changes
clearMocks: falsefrompackages/esl/vitest.config.ts.animate.mixin.test.ts: moved element initialization and microtask wait intobeforeEachso that DOM attachment and mixin discovery occur freshly for each test.esl-trigger.actions.test.ts: corrected event simulation for hover inmode: 'hide'to dispatchmouseenter(which triggers hide in hide-only mode) and added assertion for ignoredmouseleave.decorate.test.ts: consolidated interdependent@decoratelifecycle checks into self-contained test cases.target.test.ts: migrated shared suite state tobeforeEachhooks and added explicitMock<EventListener>/Mock<EventListenerObject['handleEvent']>typing to satisfy DOM event listener signatures.