Skip to content

Fix build on ethermint#17

Draft
austinchandra wants to merge 1 commit intomainfrom
austinchandra/add-ethermint-support
Draft

Fix build on ethermint#17
austinchandra wants to merge 1 commit intomainfrom
austinchandra/add-ethermint-support

Conversation

@austinchandra
Copy link

@austinchandra austinchandra commented Apr 12, 2023

Runs all nodes with ethermint. Nothing shows on Grafana, but nodes and tx bot seem to be running.

note also that this uses a local tx-bot build, once we update the deployed version we should remove that change here

Copy link
Contributor

@GAtom22 GAtom22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are OK but this will work only on the branches/releases where the changes introduced on this PR are included. For example, if you want to test v0.21.0, it will not work with the changes on this PR.

@@ -18,8 +18,7 @@ MNEMONIC="stumble tilt business detect father ticket major inner awake jeans nam
BUILD_DIR=$(pwd)/localnet/build

# TODO uncomment this when issue https://github.com/evmos/ethermint/issues/1579 is solved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: remove the comment

Suggested change
# TODO uncomment this when issue https://github.com/evmos/ethermint/issues/1579 is solved

done

echo "copy config.toml to get the seeds"
# TODO uncomment this when issue https://github.com/evmos/ethermint/issues/1579 is solved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: remove comment

Suggested change
# TODO uncomment this when issue https://github.com/evmos/ethermint/issues/1579 is solved

sed -i.bak 's/moniker = \"node0\"/moniker = \"orchestrator\"/g' $CONFIG

echo "copy app.toml to have same config on all nodes"
# TODO uncomment this when issue https://github.com/evmos/ethermint/issues/1579 is solved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit remove comment

Suggested change
# TODO uncomment this when issue https://github.com/evmos/ethermint/issues/1579 is solved

@@ -75,19 +74,16 @@ $CHAIND validate-genesis --home $DATA_DIR
echo "- Distribute final genesis.json to all validators"
for i in $(ls $BUILD_DIR | grep 'node');do
# TODO uncomment this when issue https://github.com/evmos/ethermint/issues/1579 is solved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit remove comment

Suggested change
# TODO uncomment this when issue https://github.com/evmos/ethermint/issues/1579 is solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants