Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed wrapTitle Alignment issues #2930

Merged
merged 3 commits into from
Dec 17, 2024
Merged

fixed wrapTitle Alignment issues #2930

merged 3 commits into from
Dec 17, 2024

Conversation

kwongz
Copy link
Contributor

@kwongz kwongz commented Dec 17, 2024 •
edited by zachstence
Loading

Description

Fixes #2928

Issues when using wrapTitle

image

image

Added wraptitle check to handle alignment for specific use cases

image

Checklist

  • For UI or styling changes, I have added a screenshot or gif showing before & after
  • I have added a changeset
  • I have added to the docs where applicable
  • I have added to the VS Code extension where applicable

@kwongz kwongz requested a review from hughess December 17, 2024 20:14
@zachstence
Copy link
Member

@kwongz Can you look through the Chromatic changes and accept them if they look okay?

@kwongz kwongz merged commit 43b4775 into next Dec 17, 2024
32 checks passed
@kwongz kwongz deleted the dataTable-title-prop-alignment branch December 17, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachstence zachstence zachstence approved these changes

@hughess hughess Awaiting requested review from hughess

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: DataTable wrapTitles Forces Left Column Title Alignment
2 participants
@kwongz @zachstence