-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes bug where DataTable component throws error when underlying columns in data change #2827
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jantaks, seems like there's still an issue with the DataTable
. Our base-path
and prerender
E2E tests are failing. I pulled down your branch and tried to run e2e/base-path
and when I go to the /table-row-links
page, everything freezes. Seems like there's some infinite reactivity update happening.
HI @zachstence, thanks for the feedback. I guess I should have caught this myself. This my first open source contribution ever so I am still learning. Anyways .... will look into it. |
No worries, we appreciate the contribution! |
@kwongz can you take a look and see if we can get this across the line? |
I have spent quite some time trying to resolve this. The issue for me was that there are quite a lot of interdependent reactive statements / effects in this component. I went down the route of externalizing the state in an external store but things got too complicate to wrap my head around. Typescript and Svelte5 would make this task a lot easier ... |
Hi @jantaks - I'm going to close this for now - If you get it working, feel free to reopen! |
Background:
I wanted to create a DataTable for the result of a PIVOT operation when i found that this component could not deal with the underlying column IDs changing.
The issue is caused by 2 pieces of state (columns and columSummary) that are not updated in the correct sequence during the rendering process.
See storybook: /story/viz-datatable--reactive-datatable
Before:
After:
Checklist