Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/2719 error component #2735

Merged
merged 7 commits into from
Nov 6, 2024
Merged

Fix/2719 error component #2735

merged 7 commits into from
Nov 6, 2024

Conversation

kwongz
Copy link
Contributor

@kwongz kwongz commented Nov 5, 2024

Description

image

Maps render error before leaflet map rendering

Checklist

  • For UI or styling changes, I have added a screenshot or gif showing before & after
  • I have added a changeset
  • [ ] I have added to the docs where applicable
  • [ ] I have added to the VS Code extension where applicable

@kwongz kwongz requested a review from archiewood November 5, 2024 21:20
Copy link

changeset-bot bot commented Nov 5, 2024

🦋 Changeset detected

Latest commit: 2611d5c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@evidence-dev/core-components Patch
my-evidence-project Patch
e2e-prerender Patch
e2e-spa Patch
e2e-themes Patch
@evidence-dev/components Patch
evidence-test-environment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@archiewood
Copy link
Member

From a QA perspective this seems fine. Needs an engineering review.

@kwongz
Copy link
Contributor Author

kwongz commented Nov 6, 2024

fixes #2719

@kwongz kwongz merged commit 92c3b90 into next Nov 6, 2024
21 checks passed
@kwongz kwongz deleted the fix/2719-errorComponent branch November 6, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants