Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Themes] Implement colorPalettes and colorScales config #2729

Merged
merged 7 commits into from
Nov 7, 2024
Merged

[Themes] Implement colorPalettes and colorScales config #2729

merged 7 commits into from
Nov 7, 2024

Conversation

zachstence
Copy link
Member

@zachstence zachstence commented Nov 5, 2024 •
edited
Loading

This PR implements the colorPalettes and colorScales themes config.

It also replaces chartColours and mapColours with the default color palette.

There are plenty of other places where we should use palettes and scales from config (e.g. DataTable), but I'm going to tackle those in a separate PR.

@zachstence zachstence self-assigned this Nov 5, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9bd8a8a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zachstence zachstence force-pushed the feat/2499-theming_config-options branch from e0dea9e to e87c0d6 Compare November 5, 2024 21:26
@zachstence zachstence force-pushed the feat/2499-theming_color-palettes-and-scales branch from f174ef5 to b880beb Compare November 5, 2024 21:27
@zachstence zachstence force-pushed the feat/2499-theming_config-options branch from e87c0d6 to 42c5be4 Compare November 5, 2024 21:58
@zachstence zachstence force-pushed the feat/2499-theming_color-palettes-and-scales branch from b880beb to cf64867 Compare November 5, 2024 22:07
@zachstence zachstence changed the title [Theming] Implement colorPalettes and colorScales config [Themes] Implement colorPalettes and colorScales config Nov 5, 2024
ItsMeBrianD
ItsMeBrianD approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@ItsMeBrianD ItsMeBrianD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changeset?

packages/ui/tailwind/src/themes/defaultThemesConfig.js Outdated Show resolved Hide resolved
Base automatically changed from feat/2499-theming_config-options to feat/2499-theming November 7, 2024 19:05
@zachstence
Copy link
Member Author

changeset?

Going into a feature branch so no need for a changeset here. Will have appropriate changesets on the final merge into next.

@zachstence zachstence merged commit d9398d3 into feat/2499-theming Nov 7, 2024
9 of 10 checks passed
@zachstence zachstence deleted the feat/2499-theming_color-palettes-and-scales branch November 7, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughess hughess hughess left review comments

@ItsMeBrianD ItsMeBrianD ItsMeBrianD approved these changes

Assignees

@zachstence zachstence

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zachstence @ItsMeBrianD @hughess