Skip to content

Commit

Permalink
ci: chromatic and sources tests need external-pr-action-approval
Browse files Browse the repository at this point in the history
  • Loading branch information
zachstence committed Nov 4, 2024
1 parent 5e10131 commit bcf5ee4
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 7 deletions.
8 changes: 5 additions & 3 deletions .github/workflows/chromatic.yml
Original file line number Diff line number Diff line change
@@ -1,17 +1,19 @@
name: 'Chromatic'

on:
push:
pull_request_target:

jobs:
external-pr-action-approval:
uses: ./.github/workflows/external-pr-action-approval.yml
chromatic:
needs: external-pr-action-approval
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
- uses: actions/checkout@v4
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.sha }}
- uses: pnpm/[email protected]
with:
version: 8.6.9
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@ on:

jobs:
Tests-sources:
runs-on: ${{ matrix.os }}
if: ${{ github.triggering_actor == 'archiewood' || github.triggering_actor == 'mcrascal' || github.triggering_actor == 'ud3sh' || github.triggering_actor == 'hughess' || github.triggering_actor == 'winterhart' || github.triggering_actor == 'itsmebriand' || github.triggering_actor == 'kwongz' || github.triggering_actor == 'zachstence' || github.triggering_actor == 'csjh'}}
timeout-minutes: 20

# Conditional Strategy logic from https://github.com/orgs/community/discussions/26253#discussioncomment-3250989
strategy:
fail-fast: false
Expand All @@ -25,6 +21,10 @@ jobs:
- isMain: false
os: macOS-latest

needs: ./.github/workflows/external-pr-action-approval.yml
runs-on: ${{ matrix.os }}
timeout-minutes: 20

steps:
- run: git config --global core.autocrlf false

Expand Down

0 comments on commit bcf5ee4

Please sign in to comment.