Fix context extension lifetime issue in rules#33
Merged
Conversation
Update all rule implementations to properly handle context extension. The issue was that ctx.extend() returned a temporary Box<dyn Context> that was freed immediately, causing a borrow checker error. Fixed by storing the extended context in a variable that lives long enough. Also update all integration tests to work with the new context handling. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
- Cover all RuleContext::check_rule branches: no extract, with extract, when=true, when=false, skipped, extend error, condition error - Cover GitRepoContext::extend: happy path, message_file inheritance, invalid repo error path - Cover GitRepoContext::variables: None extract and Some extract branches Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes borrow checker error when using context extension. The
ctx.extend()method returns aBox<dyn Context>that was being freed immediately, causing a temporary value lifetime issue.Changes
Test Plan
🤖 Generated with Claude Code