DEVPROD-15048: Sort waterfall tasks alphabetically by display name #8777
+68
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minnakt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-15048
Description
Right now, we are sorting by task IDs, which can lead to inconsistent results.
Consider the following case:
build-and-push-darwin-unsignedevg_build_and_push_display_build_and_push_darwin_unsigned_e2289911f2d07f303e220fd32627eb41c7517a7e_25_02_27_21_09_07build-and-pushevg_build_and_push_display_build_and_push_e2289911f2d07f303e220fd32627eb41c7517a7e_25_02_27_21_09_07Even though
build-and-pushshould come alphabetically beforebuild-and-push-darwin-unsigned, the IDs dictate otherwise due to the randomly determined version hash. We should sort by display name instead.Testing
On staging.
Before:
After:
Also added unit tests.