DEVPROD-11928 remove legacy task planner #8745
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SupaJoon
reviewed
Feb 26, 2025
| @@ -214,8 +214,6 @@ func (r *plannerSettingsResolver) Version(ctx context.Context, obj *model.APIPla | |||
| } | |||
|
|
|||
| switch utility.FromStringPtr(obj.Version) { | |||
| case evergreen.PlannerVersionLegacy: | |||
There was a problem hiding this comment.
The E2E tests are failing because the default case is triggered after removing this case statement. This can probably be fixed by adjusting the testdata and verified locally by running Spruce and Cypress.
Kimchelly
approved these changes
Feb 26, 2025
rest/model/scheduler.go
Outdated
| @@ -1,8 +1,7 @@ | |||
| package model | |||
|
|
|||
| type CompareTasksRequest struct { | |||
There was a problem hiding this comment.
Can delete this file since the compare tasks route is removed.
rest/route/distro_test.go
Outdated
| @@ -729,6 +732,7 @@ func (s *DistroPatchByIDSuite) TestRunProviderSettingsList() { | |||
| resp := s.rm.Run(ctx) | |||
| s.NotNil(resp.Data()) | |||
| s.Equal(http.StatusOK, resp.Status()) | |||
| fmt.Println(resp.Data()) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-11928
Description
Remove the legacy task planner. Similarly to how we removed legacy dispatcher versions, not fully removing the list structure or anything, since we could presumably add new versions one day.
All distros in prod are explicitly using tunable. Before merging, will update distros in staging.
evergreen-ci/ui#654
Testing
Ensured existing tests pass.
Documentation
Updated docs.