Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds support for the mETH token and Mantle network to the Everclear protocol's mainnet environments. The changes include configuration files for asset deployment scripts, network definitions, and CLI configurations.
Changes:
- Added mETH token configuration for both mainnet staging and production environments
- Added Mantle network support to the mainnet staging environment
- Updated WETH configuration to include 3 additional chains (Mantle, Base, Solana) and adjusted initialization parameters
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/contracts/script/assets/mainnetstaging/WETH.s.sol | Expanded asset configs array from 3 to 6 to include Mantle, Base, and Solana; changed initLastClosedEpochProcessed to false |
| packages/contracts/script/assets/mainnetstaging/METH.s.sol | New asset configuration script for mETH on Mantle in staging environment |
| packages/contracts/script/assets/mainnetproduction/METH.s.sol | New asset configuration script for mETH on Ethereum and Mantle in production environment |
| packages/contracts/script/MainnetStaging.sol | Added MANTLE_METH constant, updated Mantle network addresses, and added Mantle to supported domains |
| packages/contracts/script/MainnetProduction.sol | Added ETHEREUM_METH and MANTLE_METH address constants |
| packages/contracts/cli/config/spoke.json | Added Mantle spoke configuration for staging and corrected Base fee adapter address |
| packages/contracts/cli/config/domains.json | Added MainnetStaging to Mantle's environments array |
| packages/contracts/cli/config/assets/mainnetstaging.json | Added METH asset entry |
| packages/contracts/cli/config/assets/mainnetproduction.json | Added METH asset entry |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "contractName": "PufETH" | ||
| }, | ||
| { | ||
| "symbol": "METH", |
There was a problem hiding this comment.
There's an inconsistency in the symbol definition. The JSON configuration uses "METH" as the symbol, but the Solidity contract returns "mETH" (with lowercase 'm'). This should be consistent across the configuration files. Consider updating the JSON to use "mETH" to match the contract, or vice versa.
| "contractName": "PTSUSDE" | ||
| }, | ||
| { | ||
| "symbol": "METH", |
There was a problem hiding this comment.
There's an inconsistency in the symbol definition. The JSON configuration uses "METH" as the symbol, but the Solidity contract returns "mETH" (with lowercase 'm'). This should be consistent across the configuration files. Consider updating the JSON to use "mETH" to match the contract, or vice versa.
| "domainId": 8453, | ||
| "environment": "MainnetStaging" | ||
| }, | ||
| { |
There was a problem hiding this comment.
The indentation is inconsistent. This entry has extra leading spaces compared to other entries in the array. The opening brace should align with the other array elements above it.
🤖 Linear
Adding configuration for meth to the production config.