Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add site config api (BC) #9812

Merged
merged 87 commits into from
Jan 27, 2024
Merged

Add site config api (BC) #9812

merged 87 commits into from
Jan 27, 2024

Conversation

andig
Copy link
Member

@andig andig commented Sep 9, 2023

Refs #6029
fixes #10976

TODO

  • UI: CRUD for meters
  • UI: Modbus properties
  • UI: add/remove meters from site
  • UI: dirty state & restart notice
  • UI: edit site titles
  • Integration tests
  • API: Modbus defaults & values: export param defaults by removing json - struct tags
  • Verify merge config semantics @naltatis
  • read meter references from config before assigning to site, make sure to append to yaml references
  • add a test for yaml-based meters actually assigned to site @naltatis

Optional:

  • refactor dirty state
  • New test by id api without merging config (to be discussed)

@andig andig added the enhancement New feature or request label Sep 9, 2023
@andig andig mentioned this pull request Sep 9, 2023
22 tasks
@andig
Copy link
Member Author

andig commented Sep 13, 2023

@naltatis siehe auch #9820

naltatis and others added 21 commits September 18, 2023 21:41
* Translated using Weblate (French)

Currently translated at 94.9% (283 of 298 strings)

Co-authored-by: kjorand <[email protected]>
Translate-URL: https://hosted.weblate.org/projects/evcc/evcc/fr/
Translation: evcc/evcc

* Translated using Weblate (Norwegian Bokmål)

Currently translated at 94.6% (282 of 298 strings)

Co-authored-by: Allan Nordhøy <[email protected]>
Translate-URL: https://hosted.weblate.org/projects/evcc/evcc/nb_NO/
Translation: evcc/evcc

* Translated using Weblate (Arabic)

Currently translated at 13.0% (39 of 298 strings)

Translated using Weblate (Arabic)

Currently translated at 9.7% (29 of 298 strings)

Co-authored-by: Belal Affouri <[email protected]>
Translate-URL: https://hosted.weblate.org/projects/evcc/evcc/ar/
Translation: evcc/evcc

* fix toml

---------

Co-authored-by: kjorand <[email protected]>
Co-authored-by: Allan Nordhøy <[email protected]>
Co-authored-by: Belal Affouri <[email protected]>
Co-authored-by: premultiply <[email protected]>
@naltatis
Copy link
Member

All tasks done. 🎉

@andig Würde sagen, Änderungen checken und dann kann der als nächstes rein. Danach Loadpoint/Charger und/oder Tariffs (#10042).

@VolkerK62
Copy link
Contributor

Soll der noch ins release oder erst danach?

@naltatis
Copy link
Member

Ich glaube ist ein guter Kandidat für "danach"

@github-actions github-actions bot added the stale Outdated and ready to close label Jan 11, 2024
@github-actions github-actions bot closed this Jan 16, 2024
@andig andig reopened this Jan 16, 2024
@github-actions github-actions bot removed the stale Outdated and ready to close label Jan 17, 2024
@naltatis naltatis mentioned this pull request Jan 17, 2024
7 tasks
@andig
Copy link
Member Author

andig commented Jan 20, 2024

@naltatis das braucht einen merge der größtenteils vue betrifft- bist Du so nett?

core/site.go Outdated Show resolved Hide resolved
core/site.go Outdated Show resolved Hide resolved
core/site_api.go Outdated Show resolved Hide resolved
core/site_api.go Outdated Show resolved Hide resolved
core/site_api.go Outdated Show resolved Hide resolved
core/site_api.go Outdated Show resolved Hide resolved
core/site_api.go Outdated Show resolved Hide resolved
@andig
Copy link
Member Author

andig commented Jan 27, 2024

@naltatis ...und sobald die Tests da sind rein damit?

@naltatis
Copy link
Member

@naltatis ...und sobald die Tests da sind rein damit?

Yes!

@andig andig merged commit 186ba62 into master Jan 27, 2024
7 checks passed
@andig andig deleted the feature/site-api branch January 27, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Config UI: Loading states and button debounce
7 participants