-
-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: split charger into current- and power controllers #7338
Draft
andig
wants to merge
9
commits into
master
Choose a base branch
from
feature/split-charger
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+828
−487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
andig
added
backlog
Things to do later
and removed
stale
Outdated and ready to close
labels
Jun 15, 2023
andig
force-pushed
the
feature/split-charger
branch
from
August 13, 2023 10:54
7678e3d
to
0260fea
Compare
andig
force-pushed
the
feature/split-charger
branch
from
September 17, 2023 12:19
b6afb22
to
8094740
Compare
Merged
12 tasks
Amperfied solar.connect kann auch mit Leistung statt Strom gesteuert werden und schaltet darüber auch selbstständig zwischen 1P/3P. |
Just a note: with EEBUS both variants should be possible in the same charger implementation as it depends on the chargers EEBUS version and implementation which is being supported. And it can also make sense to use currents e.g. for ISO connected cars and power for PWM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an investigation into splitting chargers into:
CurrentController
: typically wall boxesPowerController
: typically heating devices, some chargers (ChargeX)TODO
Loadpoint
tocore.currentController
switchSocket
to declare required power and removeController
interfacesChargeState
as part ofCharger
, potentially separate PRRefs #6301, #7207