Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elering: add all Nordpool regions #17493

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

lka-hh
Copy link

@lka-hh lka-hh commented Nov 29, 2024

additional regions for norway (1-5) and sweden (1-4) in line 14, validvalues

additional regions for norway (1-5) and sweden (1-4) line 14, validvalues
@andig andig added the tariffs Specific tariff support label Nov 29, 2024
@andig
Copy link
Member

andig commented Nov 29, 2024

@lka-hh this invalidates the description?

/cc @naltatis how to you want to handle regions?

@andig andig requested a review from naltatis November 29, 2024 17:36
@andig andig marked this pull request as draft November 29, 2024 17:36
@naltatis
Copy link
Member

naltatis commented Dec 1, 2024

how to you want to handle regions?

@andig yes, we should introduce a field with structured country data to improve the documentation. Currently we (mis)use the descriptions field for this. When we have it structured we could introduce proper sections on the documentation page and later build multilevel selection for tariffs in config ui: "select you country > select a tariff for your country".
For now lets stick to the description workaround.

@lka-hh can you update the description accordingly?

@andig andig marked this pull request as ready for review December 1, 2024 17:17
@andig andig changed the title Update elering.yaml with additional regions of Nordpool Group Elering: add all Nordpool regions Dec 1, 2024
@andig
Copy link
Member

andig commented Dec 1, 2024

@lka-hh out of curiosity: shouldn't the same be possible for Energinet? They have dk1,2 however and those are not present here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tariffs Specific tariff support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants