-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding eslint + travis #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evancohen
added a commit
that referenced
this pull request
Jan 16, 2017
* Adding eslint + travis * Remove Dependency CI and show build status
justbill2020
added a commit
that referenced
this pull request
Feb 6, 2017
* removed "npm" and "install" packages from dependencies * fix for conf-audio.sh removes the comment line from exported file contents * Update config.schema.json fixes #519 @DannyLuu i just updated the part that allows it to save... the UI still needs to be fixed... please keep working on it... * Add missing brace. (#542) * Adding eslint + travis (#548) * Adding eslint + travis * Remove Dependency CI and show build status * Fixing path problems and first run (#549) * use path.resolve() to get files fixing up sonus.js * updating speech config schema * remove umdl beacuse we aren't using it anymore * fix sonus error on first run * better error message on first run * oh no. 😰 * don't use kiosk mode when started with dev 🚀 * Remove error when Stock names are not filled. (#551) * Remove error when Stock names are not filled. * Add missing semi-colon * Set refresh to 30mins. * Fix browser console errors with null tv show lists. (#552) * Fix browser console errors with null tv show lists. * Fix build error. I am new to angular?! * Angular doesn't need double negations? * Fixed error with language parameter and weather (#550) * Fixed typo in language variable name * Fixed typo in language variable name * Fixed wrong moment.js lang parameter * Changed handling of the language variable handling for moment.js * v0.0.10 * Create alias for starting the smart mirror from anywhere. (#555) * Create alias for starting the smart mirror from anywhere. * Update smart mirror! * Update bashrc with subshell function. * Reload bash profile upon install. * Update install message to reflect new changes * fixing fitbit * Add english resource for Fitbit. * Cycle through Fitbit statistics. * Update controller documentation and optimized service calls. * Update fitibt css for progress bar. * Add floors to Today's stats and fixed other tags. * Update fitbit EN resource. * Shortened the progress bar. * Update init logic... my bad. * Show progress bar on daily stats. * Update progress bar ot turn green when 100% * Localizing units * Update ui to display green progress bar when over 100% * Adding comments for new enpoints that I would like to integrate. * Update english locale. * Update service and controller with new api requests. * Update fitbit index html to incorporate controller function calls. * Adding all changes. * Setting groups to cycle. * Finalizating changes. * Updated views on data displayed. * Add message resources Resources added for the languanges. WIll need translations * Replaced spaces with tabs * Found the culprit!
4 tasks
evancohen
pushed a commit
that referenced
this pull request
Mar 4, 2017
* removed "npm" and "install" packages from dependencies * fix for conf-audio.sh removes the comment line from exported file contents * Update config.schema.json fixes #519 @DannyLuu i just updated the part that allows it to save... the UI still needs to be fixed... please keep working on it... * Add missing brace. (#542) * Adding eslint + travis (#548) * Adding eslint + travis * Remove Dependency CI and show build status * Fixing path problems and first run (#549) * use path.resolve() to get files fixing up sonus.js * updating speech config schema * remove umdl beacuse we aren't using it anymore * fix sonus error on first run * better error message on first run * oh no. 😰 * don't use kiosk mode when started with dev 🚀 * Remove error when Stock names are not filled. (#551) * Remove error when Stock names are not filled. * Add missing semi-colon * Set refresh to 30mins. * Fix browser console errors with null tv show lists. (#552) * Fix browser console errors with null tv show lists. * Fix build error. I am new to angular?! * Angular doesn't need double negations? * Fixed error with language parameter and weather (#550) * Fixed typo in language variable name * Fixed typo in language variable name * Fixed wrong moment.js lang parameter * Changed handling of the language variable handling for moment.js * v0.0.10 * Create alias for starting the smart mirror from anywhere. (#555) * Create alias for starting the smart mirror from anywhere. * Update smart mirror! * Update bashrc with subshell function. * Reload bash profile upon install. * Update install message to reflect new changes * fixing fitbit * Add english resource for Fitbit. * Cycle through Fitbit statistics. * Update controller documentation and optimized service calls. * Update fitibt css for progress bar. * Add floors to Today's stats and fixed other tags. * Update fitbit EN resource. * Shortened the progress bar. * Update init logic... my bad. * Show progress bar on daily stats. * Update progress bar ot turn green when 100% * Localizing units * Update ui to display green progress bar when over 100% * Adding comments for new enpoints that I would like to integrate. * Update english locale. * Update service and controller with new api requests. * Update fitbit index html to incorporate controller function calls. * Adding all changes. * Setting groups to cycle. * Finalizating changes. * Updated views on data displayed. * Add message resources Resources added for the languanges. WIll need translations * Replaced spaces with tabs * Found the culprit!
evancohen
pushed a commit
that referenced
this pull request
Mar 28, 2017
* removed "npm" and "install" packages from dependencies * fix for conf-audio.sh removes the comment line from exported file contents * Update config.schema.json fixes #519 @DannyLuu i just updated the part that allows it to save... the UI still needs to be fixed... please keep working on it... * Add missing brace. (#542) * Adding eslint + travis (#548) * Adding eslint + travis * Remove Dependency CI and show build status * Fixing path problems and first run (#549) * use path.resolve() to get files fixing up sonus.js * updating speech config schema * remove umdl beacuse we aren't using it anymore * fix sonus error on first run * better error message on first run * oh no. 😰 * don't use kiosk mode when started with dev 🚀 * Remove error when Stock names are not filled. (#551) * Remove error when Stock names are not filled. * Add missing semi-colon * Set refresh to 30mins. * Fix browser console errors with null tv show lists. (#552) * Fix browser console errors with null tv show lists. * Fix build error. I am new to angular?! * Angular doesn't need double negations? * Fixed error with language parameter and weather (#550) * Fixed typo in language variable name * Fixed typo in language variable name * Fixed wrong moment.js lang parameter * Changed handling of the language variable handling for moment.js * v0.0.10 * Create alias for starting the smart mirror from anywhere. (#555) * Create alias for starting the smart mirror from anywhere. * Update smart mirror! * Update bashrc with subshell function. * Reload bash profile upon install. * Update install message to reflect new changes * fixing fitbit * Add english resource for Fitbit. * Cycle through Fitbit statistics. * Update controller documentation and optimized service calls. * Update fitibt css for progress bar. * Add floors to Today's stats and fixed other tags. * Update fitbit EN resource. * Shortened the progress bar. * Update init logic... my bad. * Show progress bar on daily stats. * Update progress bar ot turn green when 100% * Localizing units * Update ui to display green progress bar when over 100% * Adding comments for new enpoints that I would like to integrate. * Update english locale. * Update service and controller with new api requests. * Update fitbit index html to incorporate controller function calls. * Adding all changes. * Setting groups to cycle. * Finalizating changes. * Updated views on data displayed. * Add message resources Resources added for the languanges. WIll need translations * Replaced spaces with tabs * Found the culprit!
evancohen
pushed a commit
that referenced
this pull request
Mar 28, 2017
* removed "npm" and "install" packages from dependencies * fix for conf-audio.sh removes the comment line from exported file contents * Update config.schema.json fixes #519 @DannyLuu i just updated the part that allows it to save... the UI still needs to be fixed... please keep working on it... * Add missing brace. (#542) * Adding eslint + travis (#548) * Adding eslint + travis * Remove Dependency CI and show build status * Fixing path problems and first run (#549) * use path.resolve() to get files fixing up sonus.js * updating speech config schema * remove umdl beacuse we aren't using it anymore * fix sonus error on first run * better error message on first run * oh no. 😰 * don't use kiosk mode when started with dev 🚀 * Remove error when Stock names are not filled. (#551) * Remove error when Stock names are not filled. * Add missing semi-colon * Set refresh to 30mins. * Fix browser console errors with null tv show lists. (#552) * Fix browser console errors with null tv show lists. * Fix build error. I am new to angular?! * Angular doesn't need double negations? * Fixed error with language parameter and weather (#550) * Fixed typo in language variable name * Fixed typo in language variable name * Fixed wrong moment.js lang parameter * Changed handling of the language variable handling for moment.js * v0.0.10 * Create alias for starting the smart mirror from anywhere. (#555) * Create alias for starting the smart mirror from anywhere. * Update smart mirror! * Update bashrc with subshell function. * Reload bash profile upon install. * Update install message to reflect new changes * fixing fitbit * Add english resource for Fitbit. * Cycle through Fitbit statistics. * Update controller documentation and optimized service calls. * Update fitibt css for progress bar. * Add floors to Today's stats and fixed other tags. * Update fitbit EN resource. * Shortened the progress bar. * Update init logic... my bad. * Show progress bar on daily stats. * Update progress bar ot turn green when 100% * Localizing units * Update ui to display green progress bar when over 100% * Adding comments for new enpoints that I would like to integrate. * Update english locale. * Update service and controller with new api requests. * Update fitbit index html to incorporate controller function calls. * Adding all changes. * Setting groups to cycle. * Finalizating changes. * Updated views on data displayed. * Add message resources Resources added for the languanges. WIll need translations * Replaced spaces with tabs * Found the culprit!
evancohen
pushed a commit
that referenced
this pull request
Mar 28, 2017
* removed "npm" and "install" packages from dependencies * fix for conf-audio.sh removes the comment line from exported file contents * Update config.schema.json fixes #519 @DannyLuu i just updated the part that allows it to save... the UI still needs to be fixed... please keep working on it... * Add missing brace. (#542) * Adding eslint + travis (#548) * Adding eslint + travis * Remove Dependency CI and show build status * Fixing path problems and first run (#549) * use path.resolve() to get files fixing up sonus.js * updating speech config schema * remove umdl beacuse we aren't using it anymore * fix sonus error on first run * better error message on first run * oh no. 😰 * don't use kiosk mode when started with dev 🚀 * Remove error when Stock names are not filled. (#551) * Remove error when Stock names are not filled. * Add missing semi-colon * Set refresh to 30mins. * Fix browser console errors with null tv show lists. (#552) * Fix browser console errors with null tv show lists. * Fix build error. I am new to angular?! * Angular doesn't need double negations? * Fixed error with language parameter and weather (#550) * Fixed typo in language variable name * Fixed typo in language variable name * Fixed wrong moment.js lang parameter * Changed handling of the language variable handling for moment.js * v0.0.10 * Create alias for starting the smart mirror from anywhere. (#555) * Create alias for starting the smart mirror from anywhere. * Update smart mirror! * Update bashrc with subshell function. * Reload bash profile upon install. * Update install message to reflect new changes * fixing fitbit * Add english resource for Fitbit. * Cycle through Fitbit statistics. * Update controller documentation and optimized service calls. * Update fitibt css for progress bar. * Add floors to Today's stats and fixed other tags. * Update fitbit EN resource. * Shortened the progress bar. * Update init logic... my bad. * Show progress bar on daily stats. * Update progress bar ot turn green when 100% * Localizing units * Update ui to display green progress bar when over 100% * Adding comments for new enpoints that I would like to integrate. * Update english locale. * Update service and controller with new api requests. * Update fitbit index html to incorporate controller function calls. * Adding all changes. * Setting groups to cycle. * Finalizating changes. * Updated views on data displayed. * Add message resources Resources added for the languanges. WIll need translations * Replaced spaces with tabs * Found the culprit!
evancohen
pushed a commit
that referenced
this pull request
Mar 28, 2017
* removed "npm" and "install" packages from dependencies * fix for conf-audio.sh removes the comment line from exported file contents * Update config.schema.json fixes #519 @DannyLuu i just updated the part that allows it to save... the UI still needs to be fixed... please keep working on it... * Add missing brace. (#542) * Adding eslint + travis (#548) * Adding eslint + travis * Remove Dependency CI and show build status * Fixing path problems and first run (#549) * use path.resolve() to get files fixing up sonus.js * updating speech config schema * remove umdl beacuse we aren't using it anymore * fix sonus error on first run * better error message on first run * oh no. 😰 * don't use kiosk mode when started with dev 🚀 * Remove error when Stock names are not filled. (#551) * Remove error when Stock names are not filled. * Add missing semi-colon * Set refresh to 30mins. * Fix browser console errors with null tv show lists. (#552) * Fix browser console errors with null tv show lists. * Fix build error. I am new to angular?! * Angular doesn't need double negations? * Fixed error with language parameter and weather (#550) * Fixed typo in language variable name * Fixed typo in language variable name * Fixed wrong moment.js lang parameter * Changed handling of the language variable handling for moment.js * v0.0.10 * Create alias for starting the smart mirror from anywhere. (#555) * Create alias for starting the smart mirror from anywhere. * Update smart mirror! * Update bashrc with subshell function. * Reload bash profile upon install. * Update install message to reflect new changes * fixing fitbit * Add english resource for Fitbit. * Cycle through Fitbit statistics. * Update controller documentation and optimized service calls. * Update fitibt css for progress bar. * Add floors to Today's stats and fixed other tags. * Update fitbit EN resource. * Shortened the progress bar. * Update init logic... my bad. * Show progress bar on daily stats. * Update progress bar ot turn green when 100% * Localizing units * Update ui to display green progress bar when over 100% * Adding comments for new enpoints that I would like to integrate. * Update english locale. * Update service and controller with new api requests. * Update fitbit index html to incorporate controller function calls. * Adding all changes. * Setting groups to cycle. * Finalizating changes. * Updated views on data displayed. * Add message resources Resources added for the languanges. WIll need translations * Replaced spaces with tabs * Found the culprit!
justbill2020
pushed a commit
that referenced
this pull request
Mar 29, 2017
* Adding eslint + travis * Remove Dependency CI and show build status
justbill2020
added a commit
that referenced
this pull request
Mar 29, 2017
* Adding eslint + travis (#548) * Adding eslint + travis * Remove Dependency CI and show build status * Fixing path problems and first run (#549) * use path.resolve() to get files fixing up sonus.js * updating speech config schema * remove umdl beacuse we aren't using it anymore * fix sonus error on first run * better error message on first run * oh no. 😰 * don't use kiosk mode when started with dev 🚀 * v0.0.10 * correct error message for missing config * Mirror CLI fixes (#559) * check for dev flag at any position * alias mirror to npm run * * updating text at the end of the install script * config prompt update * moving to tabs * use config to specify recording device * update config schema init config.schema.json update * updated `speech/config.schema.json` * moved `config.default.json` and `config.schema.js` files to `remote` folder * renamed `config.default.json` to `.config.default.json` so that it is hidden on most default builds of linux... this is an attempt of keeping long time users from changing the file as was the old process when updating smart-mirror prior to remote configUI... * updated main.js, remote.js and index.html to reflect these changes use config to specify recording device update config schema init config.schema.json update * updated `speech/config.schema.json` * moved `config.default.json` and `config.schema.js` files to `remote` folder * renamed `config.default.json` to `.config.default.json` so that it is hidden on most default builds of linux... this is an attempt of keeping long time users from changing the file as was the old process when updating smart-mirror prior to remote configUI... * updated main.js, remote.js and index.html to reflect these changes use config to specify recording device * minor changes * add device functionality and range value updates * fix eslint issues * fix main after rebase * squashing mic input work * fix default configs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A step in the right direction for #323. In the future I'd like to have even stricter linting (tabs/spaces etc) but this is about baby steps. We'll also need some real tests!