Repository navigation
Web app setup: Phaser, Vite, Pages build - #36
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kd8cM95An5P8HxDJ2tRecM
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kd8cM95An5P8HxDJ2tRecM
evan-rawson-software
left a comment
Owner
Author
There was a problem hiding this comment.
Verdict: APPROVE
Required fixes: none.
Checked on a clean checkout of the branch head (d0e5891):
npm ci,npm run typecheck,npm test(21 passed) andnpm run buildall pass.- Served with
vite preview --base /pass-the-spark/and loaded in Playwright. The canvas is 1920x1080, scaled to fit and centred. The background is table green and "Pass the Spark" is drawn. The page and JS bundle load from/pass-the-spark/with 200s. There are no console errors, only WebGL driver performance warnings from headless Chromium. The preview server has been stopped. - Dependencies: only
phaser4.2.1 andvite8.3.8 were added, both the current npm versions. The lockfile is committed and only gained phaser and eventemitter3 as new packages. - Layout:
src/game/holds the screen code. Nothing insrc/engine/imports from it, and there is no game logic insrc/game/.tsconfigstill includessrc, sosrc/game/is type-checked, andvite.config.tsis added. CLAUDE.mdhas the one-line screen rule, plusdevandbuildin Commands.deploy.ymluses setup-node with the npm cache, thennpm ci,npm run build, and uploadsdist. Permissions and concurrency are unchanged.actions/checkout,setup-node,configure-pages,upload-pages-artifactanddeploy-pagesare on v7, v7, v6, v5 and v5, which are the latest majors fromgit ls-remote.site/is removed, with its page moved to the rootindex.html.ci.ymlis untouched. There are no tests, as the issue says. Nothing out of scope.
Spec questions: none.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the browser game shell: Phaser 4.2.1 and Vite 8.3.8,
src/game/for screen code, an empty 1920x1080 scene (Scale.FIT, centred, table-green background) saying "Pass the Spark". Vitebaseis/pass-the-spark/.deploy.ymlnow runsnpm ciandnpm run buildand deploysdist/;site/is removed.CLAUDE.mdhas the screen-code rule and thedev/buildcommands.Verified locally:
npm run typecheck,npm testandnpm run buildpass. The dev server renders the scene in headless Chromium with no console errors.Closes #21
Generated by Claude Code