-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sentry call #65
Open
shreyasjayanna
wants to merge
8
commits into
evalphobia:master
Choose a base branch
from
NinthDecimal:update-sentry-call
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+43
−36
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d8431cc
Updated references to internal kiip fork
jspeyside 61accc1
Renamed references to kiip library
jspeyside b76237f
Force build
jspeyside f29573d
Merge pull request #1 from kiip/internal-fork
jspeyside e993e30
Update to keep code coverage
jspeyside 0ffc23a
Merge pull request #2 from kiip/coverage
jspeyside 07670f0
Update Sentry call
c026e7a
Merge branch 'master' into update-sentry-call
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
coverage.out | ||
logrussentry |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,23 @@ | ||
sudo: false | ||
language: go | ||
go: | ||
- 1.4 | ||
- 1.5 | ||
- 1.6 | ||
- 1.7 | ||
- tip | ||
matrix: | ||
allow_failures: | ||
- go: tip | ||
- 1.9 | ||
|
||
env: | ||
global: | ||
secure: swil3Y+gIZkN/Ch6NF13dM1QPF+rABiW5kTSP149arwwu1tcDGIv/64zifGzrOxkrez9ZUQzJs5fqsBtRX5p4Q8hC7s8D+3On5TqLovPUr4Pu5Fjy4VJdGz6NaD1Zp1hcwBPJo30efI16utACfjDSuvGhc2s3W98LmZJajaNqVbDFYOkCgZQgIToWeMQ25ZcObvsM+RrJUsZMndSaCZ0N4JTA3fb4uygOmd60qo/kcoiYbp7daP0cshq9IggcQPlPgVraodmY4MLy5bCRHtN6xzqa0DfzvGHqPp815pIYCYi2AxfdkrnUz1ZZxGIv7lrC4MHe+kC7YSe1YhJYfxEFInXhbOd5bcdQeJ0By1V0woku5wzXU7MrE4ZqzABYUhbEFdyWFrBqkvMWkLE70uFhpRxQgE8x9C0qbjY7/yNK0RRPXyiGn98kk6eio+H1fPdxUI/PlrmblUiObvjnWZo+rSWajSlzdYzFvY+OOrP3H7dSQTbotsqqqQYyIILxOX+zbQR+SNlRURqhra7xOreYSSaCyZBzCi0O3B4iz2AdwRdb6OVz7YRIJZuOr02Ht+H0csnzMs3IWHxjLxB6SmpQvZ1cMUy04vgQWsghcTip1jVsU5oTYLtW0V501p0DjcLdzKo6lj+fddjMLeV0Ok6S1v717Cu03DaMYzbp2VnXjI= | ||
|
||
before_install: | ||
- go get github.com/axw/gocov/gocov | ||
- go get github.com/mattn/goveralls | ||
- if ! go get github.com/golang/tools/cmd/cover; then go get golang.org/x/tools/cmd/cover; fi | ||
- if ! go get github.com/golang/tools/cmd/cover; then go get golang.org/x/tools/cmd/cover; | ||
fi | ||
|
||
before_script: | ||
- go vet ./... | ||
- gofmt -s -l . | ||
|
||
script: | ||
- $HOME/gopath/bin/goveralls -service=travis-ci | ||
- go test -v -covermode=count -coverprofile=coverage.out | ||
- "$HOME/gopath/bin/goveralls -coverprofile=coverage.out -service=travis-ci -repotoken | ||
$COVERALLS_TOKEN" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
package logrus_sentry | ||
package logrussentry | ||
|
||
import ( | ||
"fmt" | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this fn call need to fix quickly ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evalphobia
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So only this line is needed to follow changed parameters onNewStacktraceFrame
?Sorry, I thought this PR was accidentally created by mistake.Should I create new PR or @shreyasj2006 would you fix this PR ?@naiba Sorry, I forgot merging and already fixed by @Sef1995
#66