🛡️ Sentinel: [HIGH] Fix CWE-400 (Slowloris) vulnerability

[euxaristia]

🛡️ Sentinel: [HIGH] Fix CWE-400 (Slowloris) vulnerability

🚨 Severity: HIGH
💡 Vulnerability: Found http.Server instances without ReadHeaderTimeout set, leaving the application vulnerable to CWE-400 Slowloris attacks. Default http.Server configurations do not timeout reading headers, which can be exploited by an attacker holding connections open indefinitely by sending partial HTTP requests.
🎯 Impact: If exploited, an attacker could consume all available server connections, leading to denial of service for legitimate users.
🔧 Fix: Added ReadHeaderTimeout: 3 * time.Second to http.Server initialization in internal/provideroauth/openrouter.go, internal/mcp/oauth.go, internal/tools/bash_tool_test.go, and internal/oauth/loopback.go.
✅ Verification: Verified by running make lint and make test. No linting errors or regressions were found.

This issue has also been documented in the Sentinel journal .jules/sentinel.md.

---

PR created automatically by Jules for task 1262716765925440462 started by @euxaristia

Summary by CodeRabbit

• Security
  • Added a three-second request-header timeout to OAuth callback servers, reducing exposure to slow HTTP requests.
  • Applied the same timeout to the related HTTP test server configuration.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3b91ac60-2383-4495-8af7-cd5c8730124e

📥 Commits

Reviewing files that changed from the base of the PR and between 2458e0c and 5f021a8.

📒 Files selected for processing (5)

• .jules/sentinel.md
• internal/mcp/oauth.go
• internal/oauth/loopback.go
• internal/provideroauth/openrouter.go
• internal/tools/bash_tool_test.go

---

Walkthrough

The change adds a three-second ReadHeaderTimeout to OAuth callback servers and the Bash tool test server. Sentinel documentation records the related Slowloris vulnerability and configuration requirement.

Changes

OAuth server timeout hardening

Layer / File(s)	Summary
OAuth callback server timeouts internal/oauth/loopback.go, internal/mcp/oauth.go, internal/provideroauth/openrouter.go	OAuth callback HTTP servers now enforce a three-second ReadHeaderTimeout. Callback routing and responses remain unchanged.
Test coverage and security guidance internal/tools/bash_tool_test.go, .jules/sentinel.md	The Bash tool test server applies the timeout. Sentinel guidance documents the missing configuration and Slowloris impact.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• euxaristia/zero#10: Modifies the same OAuth and loopback server configurations with a different timeout value.
• euxaristia/zero#11: Updates the same server initializations and Sentinel documentation.
• euxaristia/zero#13: Applies related ReadHeaderTimeout changes to the same files.

Suggested reviewers: gnanam1990, vasanthdev2004

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the primary change: mitigating the CWE-400 Slowloris vulnerability with HTTP header read timeouts.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch sentinel-fix-cwe-400-slowloris-1262716765925440462

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Zero automated PR review

Verdict: No blockers found

Blockers

• None found.

Validation

• [pass] Diff hygiene: git diff --check
• [pass] Tests: go test ./...
• [pass] Build: go run ./cmd/zero-release build
• [pass] Smoke build: go run ./cmd/zero-release smoke

Scope

Head: 5f021a8dcfa3
Changed files (5): .jules/sentinel.md, internal/mcp/oauth.go, internal/oauth/loopback.go, internal/provideroauth/openrouter.go, internal/tools/bash_tool_test.go

This deterministic review checks validation status and basic diff hygiene. A human reviewer still owns product judgment and design quality.