Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safely exit format on mismatch argument #396

Merged
merged 2 commits into from
Oct 10, 2019

Conversation

Affonso-Gui
Copy link
Member

Fix the following bug, when format is interrupted with mismatch argument error:

(format t "~S" (list "abc" 10))
;; ("abc" 10)

(format t "~A")
Call Stack (max depth: 20):
  0: at (format t ~A)
  1: at #<compiled-code #X64c1e28>
eus 0 error: mismatch argument in (format t ~A)

(format t "~S" (list "abc" 10))
;; (abc 10) < correct is ("abc" 10) , with quotes

This happens because the argument check included in nextfarg is done after the slashflag is altered, leaving it stuck at 1 after the error occurs.

@Affonso-Gui
Copy link
Member Author

ci/circleci seems to be failing with

$ sudo apt-get install -qq -y texlive-latex-base ptex-bin latex2html nkf poppler-utils
E: Package 'ptex-bin' has no installation candidate
E: Unable to locate package latex2html
E: Unable to locate package nkf
Exited with code 100

but the standard tests are passing normally.

@k-okada Do we need to update something in the ci/circleci or is just a matter of timing?

@Affonso-Gui
Copy link
Member Author

@k-okada All tests are passing now! Thanks for the fix.

@k-okada k-okada merged commit 6a25da0 into euslisp:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants