Android/gap fixes retry validation paging ws - #157
Open
laddyr141-ui wants to merge 4 commits into
Open
Conversation
A transient timeout (now bounded by HttpTimeout) previously surfaced immediately as ApiResult.Error with no retry. get() now retries transient network failures (timeouts, IOExceptions) with exponential backoff via a new RetryPolicy/withRetry helper, mirroring iOS's RetryPolicy.swift. post()/delete() remain single-attempt so a retried mutation can never double-submit (check-in, withdrawal, 2FA disable, ...). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
CreateVaultDialog only required beneficiary.isNotBlank() before enabling Create, matching iOS's ethos-protocol#22 gap. Port iOS's StellarAddress StrKey validator (ed25519 public key: length/prefix/version byte/CRC16-XModem checksum) to Kotlin and require it before Create is enabled, with inline validation feedback in the dialog. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ApiClient.listVaults() and VaultViewModel.load() assumed the full vault list fit in a single response, matching iOS's ethos-protocol#21 gap. Add offset/limit query params to GET /vaults (documented in shared/api-contract.md as VaultPage, coordinated with ethos-protocol#21), a VaultViewModel.loadMore() that appends subsequent pages, and a "Load more" control in VaultListScreen's LazyColumn. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
shared/api-contract.md documents wss://.../ws?vault_id={id}, but no
client existed anywhere in the Android app and Ktor's WebSockets
plugin wasn't installed, matching iOS's ethos-protocol#20 gap. Install WebSockets
on the existing HttpClient in ApiClient, add a VaultEventSocket
service with reconnect/exponential-backoff (resetting on each
successful connection), and wire it into VaultViewModel to update
the matching vault in place as events arrive.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
@laddyr141-ui Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
listVaults()#70CreateVaultDialog#71ApiClient's Network Layer #72