This repository was archived by the owner on Aug 2, 2021. It is now read-only.
swap: remove honeyOracle #2132
Open
swap: remove honeyOracle #2132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortelli
approved these changes
Mar 12, 2020
Contributor
mortelli
left a comment
mortelli
left a comment
There was a problem hiding this comment.
LGTM
thanks for doing this cleanup
acud
approved these changes
Apr 1, 2020
Contributor
|
needs a rebase/pull master |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
honeyOraclewhich was supposed to convert from honey to ether. As honey is now its own token it can be removed.This PR still keeps the
cheque.Honeyfield. This could also be removed now.