This repository was archived by the owner on Mar 7, 2026. It is now read-only.
fix: resolve DataTable pagination dropdown sync and AppShell border styling issues#63
Merged
christoph2806 merged 2 commits intodevelopfrom Jun 12, 2025
Conversation
This was referenced Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: DataTable Pagination Dropdown Sync and AppShell Border Styling Issues
🐛 Issues Fixed
1. DataTable Pagination Dropdown Synchronization
pageSizeOptions2. AppShell Border Styling Inconsistencies
#000000,border-gray-200) instead of design system tokens🔧 Solutions Implemented
DataTable Pagination Fixes
pageSizeis always included inpageSizeOptionsSetto prevent duplicate values in dropdownAppShell Styling Fixes
hsl(var(--border)),hsl(var(--foreground)))AppShell,AppShellTopBar,ContentWrapper🧪 Testing
📝 Files Changed
packages/ui-kit/src/components/data-display/DataTable/DataTable.tsx- Pagination sync fixespackages/ui-kit/src/layout/AppShell/AppShell.tsx- Footer border fixpackages/ui-kit/src/layout/AppShell/AppShellTopBar.tsx- Top bar border fixpackages/ui-kit/src/layout/AppShell/ContentWrapper.tsx- Content wrapper border fixespackages/ui-kit/src/components/primitives/MarkdownEditor/MarkdownEditor.tsx- Text color fix🎯 Verification Steps
pageSizenot in default options → Dropdown shows correct value📋 Closes
Fixes pagination dropdown synchronization issues and AppShell styling inconsistencies identified during component testing.