Skip to content
This repository was archived by the owner on Mar 7, 2026. It is now read-only.

fix: resolve DataTable pagination dropdown sync and AppShell border styling issues#63

Merged
christoph2806 merged 2 commits intodevelopfrom
bugfix/appshell-borders-and-pagination-dropdown
Jun 12, 2025
Merged

fix: resolve DataTable pagination dropdown sync and AppShell border styling issues#63
christoph2806 merged 2 commits intodevelopfrom
bugfix/appshell-borders-and-pagination-dropdown

Conversation

@christoph2806
Copy link
Copy Markdown
Member

@christoph2806 christoph2806 commented Jun 12, 2025

Fix: DataTable Pagination Dropdown Sync and AppShell Border Styling Issues

🐛 Issues Fixed

1. DataTable Pagination Dropdown Synchronization

  • Problem: Pagination dropdown could get out of sync with actual page size when custom page sizes weren't included in pageSizeOptions
  • Impact: Users would see incorrect selected values in the dropdown, causing confusion about current pagination state

2. AppShell Border Styling Inconsistencies

  • Problem: Hard-coded color values (#000000, border-gray-200) instead of design system tokens
  • Impact: Inconsistent theming across components, poor dark mode support

🔧 Solutions Implemented

DataTable Pagination Fixes

  • ✅ Enhanced smart pagination configuration to ensure pageSize is always included in pageSizeOptions
  • ✅ Implemented automatic deduplication using Set to prevent duplicate values in dropdown
  • ✅ Applied consistent sorting to maintain proper option order
  • ✅ Fixed both controlled and auto-detected pagination scenarios

AppShell Styling Fixes

  • ✅ Replaced hard-coded colors with design system tokens (hsl(var(--border)), hsl(var(--foreground)))
  • ✅ Updated all AppShell components: AppShell, AppShellTopBar, ContentWrapper
  • ✅ Fixed MarkdownEditor text color consistency
  • ✅ Improved theme compatibility (dark/light mode support)

🧪 Testing

  • ✅ All existing tests pass (1028 tests passed, 7 skipped)
  • ✅ Linting passes with no errors
  • ✅ Build successful
  • ✅ Manual verification of pagination dropdown sync
  • ✅ Visual verification of consistent borders across themes

📝 Files Changed

  • packages/ui-kit/src/components/data-display/DataTable/DataTable.tsx - Pagination sync fixes
  • packages/ui-kit/src/layout/AppShell/AppShell.tsx - Footer border fix
  • packages/ui-kit/src/layout/AppShell/AppShellTopBar.tsx - Top bar border fix
  • packages/ui-kit/src/layout/AppShell/ContentWrapper.tsx - Content wrapper border fixes
  • packages/ui-kit/src/components/primitives/MarkdownEditor/MarkdownEditor.tsx - Text color fix

🎯 Verification Steps

  1. Create a DataTable with custom pageSize not in default options → Dropdown shows correct value
  2. Switch between page sizes → No sync issues
  3. Test AppShell components in light/dark themes → Consistent borders
  4. Verify MarkdownEditor disabled state → Proper text color

📋 Closes

Fixes pagination dropdown synchronization issues and AppShell styling inconsistencies identified during component testing.

@christoph2806 christoph2806 merged commit f3d40a7 into develop Jun 12, 2025
7 checks passed
@christoph2806 christoph2806 deleted the bugfix/appshell-borders-and-pagination-dropdown branch June 12, 2025 11:25
@christoph2806 christoph2806 added bug Something isn't working enhancement New feature or request labels Jun 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: DataTable Pagination Dropdown Synchronization Issue [Bug] AppShell uses hardcoded black borders instead of theme-aware colors

1 participant