switch PERCENTAGE_MULTIPLIER from 2**24 to 10**6 to improve readability#77
switch PERCENTAGE_MULTIPLIER from 2**24 to 10**6 to improve readability#77matthiaszimmermann wants to merge 1 commit intodevelopfrom
Conversation
| bytes32 public constant INSURER_ROLE = keccak256("INSURER"); | ||
|
|
||
| uint256 public constant PERCENTAGE_MULTIPLIER = 2**24; | ||
| uint256 public constant PERCENTAGE_MULTIPLIER = 10**6; |
There was a problem hiding this comment.
Is this a breaking change? This will have impact on all contracts stored on the blockchain as they now contain wrong values, correct?
There was a problem hiding this comment.
yes, you're correct this is a breaking change. unless we would migrate the existing data.
probably bad idea to do this during a season
There was a problem hiding this comment.
could be handled by defining that we do not merge develop into mine while the season is running
needs to be properly discussed
There was a problem hiding this comment.
Lets discuss it when you're back.
|
|
3 participants
No description provided.