Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement pectra devnet-5 spec #3807
base: master
Are you sure you want to change the base?
Implement pectra devnet-5 spec #3807
Changes from 5 commits
f290abe
85e937a
3525a19
4800a9f
d4e9496
caa9e1c
74a2123
7f5c4c5
13aafd6
fc3c150
fb7e67f
98806ff
5079664
c827859
e4adff7
34a4882
3938e7f
b665335
eadbf2c
e2b355a
4b863bf
a178857
4a9b0c2
b195bbb
df63978
90fc63a
3d1a61f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just confirming my thinking. These only get computed once at run time, right? They aren't recomputed every single time we access this code are they?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only computed once! Can also move it somewhere else like
types.ts
.Check warning on line 91 in packages/evm/src/opcodes/functions.ts
Codecov / codecov/patch
packages/evm/src/opcodes/functions.ts#L87-L91
Check warning on line 98 in packages/evm/src/opcodes/functions.ts
Codecov / codecov/patch
packages/evm/src/opcodes/functions.ts#L94-L98
Check warning on line 566 in packages/evm/src/opcodes/functions.ts
Codecov / codecov/patch
packages/evm/src/opcodes/functions.ts#L566
Check warning on line 588 in packages/evm/src/opcodes/functions.ts
Codecov / codecov/patch
packages/evm/src/opcodes/functions.ts#L588
Check warning on line 616 in packages/evm/src/opcodes/functions.ts
Codecov / codecov/patch
packages/evm/src/opcodes/functions.ts#L616