-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mpt: simplify rangeProof handling & flatten mpt file structure #3740
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record: I liked the non-flattened version a bit more, would not make this a blocker though.
What is important (necessary) though: have these files been moved by git
? (GitHub then normally shows the transition) Otherwise we would loose git history for these files. So if not, this would need an update.
I've decided to restore the initial folder structure, and only do the other updates (refactoring of the rangeProof etc.) |
Client tests not going through |
fixed by re-running |
This addresses this comment and makes some misc minor improvemnts to the mpt package.