[WIP] Introduce universal compilation host to execution framework #15960
+798
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
erak
force-pushed
the
test-compiler-host
branch
from
08ce0db to
9387714
Compare
erak
force-pushed
the
test-compiler-host
branch
2 times, most recently
from
0067fdd to
6a47a21
Compare
erak
force-pushed
the
test-compiler-host
branch
from
6a47a21 to
9e50f8c
Compare
|
There was an error when running Please check that your changes are working as intended. |
| mappedContracts.insert(std::make_pair(name.source(), contracts)); | ||
| } | ||
| } | ||
|
|
| } | ||
| } | ||
|
|
||
|
|
| } | ||
|
|
||
|
|
||
|
|
|
|
||
| // for (auto sourceName: m_stack.sourceNames()) | ||
| // { | ||
| // std::cout << "sourceName: " << sourceName << std::endl; |
| // auto const& sourceUnit = m_stack.ast(sourceName); | ||
| // for (auto const* contract: ASTNode::filteredNodes<ContractDefinition>(sourceUnit.nodes())) | ||
| // { | ||
|
|
erak
force-pushed
the
test-compiler-host
branch
from
f79fbae to
3b47946
Compare
| ContractName{_mainSourceName.value_or(""), contractName.contract()} : | ||
| contractName; | ||
|
|
||
| std::cout << "Looking up contract \"" << contractName.source() << ":" << contractName.contract() << "\"..." << std::endl; |
| mappedContracts.insert(std::make_pair(name.source(), contracts)); | ||
| } | ||
| } | ||
|
|
| } | ||
| } | ||
|
|
||
|
|
| } | ||
|
|
||
|
|
||
|
|
|
|
||
| // for (auto sourceName: m_stack.sourceNames()) | ||
| // { | ||
| // std::cout << "sourceName: " << sourceName << std::endl; |
| // auto const& sourceUnit = m_stack.ast(sourceName); | ||
| // for (auto const* contract: ASTNode::filteredNodes<ContractDefinition>(sourceUnit.nodes())) | ||
| // { | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a universal compiler host for running tests with various compilers (etc. the internal compiler aka.
CompilerStackor standard JSON compiler).Details
It introduces some common types for the compiler inputs and its output. A compilation module that wraps the linked / internal compiler was added. It can be used in a newly added universal compiler host. This host is then used inside the test execution framework.
Outlook
The input / output types introduced by this PR were inspired by the
SolidityCompilationFramework. In a future PR the universal compiler host could be used there as well.Ultimately, this PR makes it possible to implement a compilation module for the standard JSON compiler as well and use that in the pipeline.