Name dependent CSE bug: Compare ASM only #15942
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clonker
force-pushed
the
name_dependent_cse_bug_only_asm
branch
from
33af0e1 to
dec7b16
Compare
cameel
approved these changes
Mar 14, 2025
cameel
force-pushed
the
name_dependent_cse_bug_only_asm
branch
from
dec7b16 to
145e281
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method implemented in #15838 will lead to the replaced
_1and_2being preserved, making the test fail as the pretty printed source is no longer identical for the two cases. This PR changes the test so that only ASM output is produced and subsequently compared which is invariant under the change in label.