Use Helios #19
Draft
Use Helios #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xpensive warmup upon construction
…r Helios, also useHelios instead of preferHelios, throw exception rather than falling back to non-Helios
voltrevo
commented
Oct 15, 2025
| rpcUrls: string[] | ||
| explorerUrl: string | ||
| selectedRpcUrl: string | ||
| consensusRpcUrl?: string |
There was a problem hiding this comment.
Used for sourcing beacon chain data
voltrevo
commented
Oct 15, 2025
| nativeAssetId: NetworkInfo['nativeAssetId'] | ||
| iconUrls?: string[] | ||
| isOptimistic?: NetworkInfo['isOptimistic'] | ||
| isLinea?: boolean |
There was a problem hiding this comment.
Required for Helios to know the type of network it needs to sync
voltrevo
commented
Oct 15, 2025
| has7702: boolean | ||
| allowForce4337?: boolean | ||
| disabled?: boolean | ||
| batchMaxCount?: number |
There was a problem hiding this comment.
Pre-existing parameter that used to be part of a separate ProviderOptions param when calling getRpcProvider.
voltrevo
commented
Oct 15, 2025
| allowForce4337?: boolean | ||
| disabled?: boolean | ||
| batchMaxCount?: number | ||
| useHelios?: boolean |
There was a problem hiding this comment.
When true, use Helios if possible, or throw exception.
- Force usage of regular JsonRpcProvider for unit testing, no Helios - Only use Helios to test getRpcProvider factory
karen-sarkisyan
had a problem deploying
to
tests
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matching PR for extension: ethereum/kohaku-extension#61.
getRpcProviderby accepting the fields fromNetworkas the only parameter, with onlyrpcUrlsrequiredHeliosEthersProvideras a compatible wrapper ofHeliosProviderwithin theetherssystem (by implementingAbstractProvider)HeliosEthersProviderwhen the newNetworkfielduseHeliosis truegetRpcProvider.tsTest failures: I am still getting test failures, but I'm no longer getting any failures that don't also occur in
main.Most failures are also present in ambire-common. They are working on fixing this.