-
Notifications
You must be signed in to change notification settings - Fork 141
zkvm: allow using entire gas in bytecode attack #1575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+19
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsign
commented
May 7, 2025
eb0aa22
to
b4ea57b
Compare
jsign
commented
May 13, 2025
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
dd465e5
to
b2f4b2f
Compare
marioevz
approved these changes
May 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, hope that the rebase helps with the CI timeout :)
Signed-off-by: Ignacio Hagopian <[email protected]>
felix314159
pushed a commit
to felix314159/execution-spec-tests
that referenced
this pull request
May 16, 2025
* zkvm: full bytecode attack enabling Signed-off-by: Ignacio Hagopian <[email protected]> * set gas limit in ci Signed-off-by: Ignacio Hagopian <[email protected]> * add slow mark Signed-off-by: Ignacio Hagopian <[email protected]> --------- Signed-off-by: Ignacio Hagopian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a way to fill the bytecode attack, solving two main problems:
postState
, which also bloats the fixture. (This PR now uses a new feature introduced in Add optional field to exclude including postState #1578)Results:
--block-gas-limit 36M
Fill command:
uv run fill --from=Cancun --until=Cancun -m "zkevm and blockchain_test" --block-gas-limit 36000000 -k test_worst_bytecode