Skip to content

fix(solc): don't install solc via solc-select on ARM; add version sanity check #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 14, 2025
Merged

fix(solc): don't install solc via solc-select on ARM; add version sanity check #1556

merged 3 commits into from
May 14, 2025
+37 −1

Conversation

felix314159
Copy link
Collaborator

@felix314159 felix314159 commented May 6, 2025 •
edited by danceratopz
Loading

🗒️ Description

Read the issue for more context

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@danceratopz danceratopz changed the title ARM solc-select workarounds and sanity version check (Issue #1512) chore(fill): ARM solc-select workarounds and sanity version check May 6, 2025
@danceratopz danceratopz added type:chore Type: Chore scope:fill Scope: fill command labels May 6, 2025
danceratopz
danceratopz reviewed May 6, 2025
View reviewed changes
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two small comments below!

danceratopz
danceratopz reviewed May 6, 2025
View reviewed changes
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two last comments.

@felix314159 felix314159 force-pushed the solc-versioning-checks branch from 9c03fb8 to b588eff Compare May 7, 2025 09:19
@felix314159
Copy link
Collaborator Author

Done!

@danceratopz danceratopz changed the title chore(fill): ARM solc-select workarounds and sanity version check fix(solc): don't install solc via solc-select on ARM; add version sanity check May 14, 2025
@danceratopz danceratopz added type:bug Something isn't working and removed type:chore Type: Chore labels May 14, 2025
danceratopz
danceratopz approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

I added a changelog to increase visibility for any other ARM users 🙂

@danceratopz danceratopz force-pushed the solc-versioning-checks branch from ba5c12f to 395a89c Compare May 14, 2025 11:33
@danceratopz danceratopz merged commit 5c16cfb into ethereum:main May 14, 2025
11 checks passed
felix314159 added a commit to felix314159/execution-spec-tests that referenced this pull request May 16, 2025
@felix314159 @danceratopz
fix(solc): don't install solc via solc-select on ARM; add version…
1366a31 
… sanity check (ethereum#1556)

Co-authored-by: danceratopz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danceratopz danceratopz danceratopz approved these changes

Assignees
No one assigned
Labels
scope:fill Scope: fill command type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felix314159 @danceratopz