Add a test with a consolidation and deposit request in the same block #4113
Conversation
jtraglia
changed the title
There was a problem hiding this comment.
a test to check that the effective balance of a validator does not change if such a validator
It does change though 😄 the source validator's excess balance (mod 1 ETH) becomes its effective balance.
This is a useful new test because it ensures deposits are processed before consolidations. Thank you!
| # 2) Create deposit request | ||
| deposit = prepare_pending_deposit( | ||
| spec, validator_index=source_index, | ||
| amount=spec.MIN_ACTIVATION_BALANCE, signed=True |
There was a problem hiding this comment.
I suggest changing the deposit amount to spec.EFFECTIVE_BALANCE_INCREMENT so that we can see that the source validator's new effective balance has changed.
| # 5) Check that balance increased but effective balance remained unchanged | ||
| assert state.balances[source_index] == spec.MIN_ACTIVATION_BALANCE | ||
| assert state.validators[source_index].effective_balance == spec.MIN_ACTIVATION_BALANCE |
There was a problem hiding this comment.
Then update this comment & these asserts.
|
Hmm after further review, this test isn't setup quite right. It's sort of an impossible situation currently. Because we didn't run |
This PR adds a test to check that the effective balance of a validator does not change if such a validator on the EL sent two requests on the same block, namely a deposit and a consolidation request (which in theory would allow him to increase his effective balance). However, this is not the case, so the test proves this behavior.