-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-7212: Move to Moved #8101
Conversation
✅ All reviewers have approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Carl. Thanks for applying decided changes on EIP->RIP process. I recommend also deleting following files which are referenced by the EIP:
- ./assets/eip-7212/p256Verify_benchmark_test
- ./assets/eip-7212/ecrecover_benchmark_test
ACK, thanks @ulerdogan, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we can "move" and not "remove". At the time of EIP/ERC split many ERCs were moved out of EIPs repo but ERC history was preserved. Like this. |
Interesting, I like it! I have updated the EIP to refer to its new RIP home as you suggested @poojaranjan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
Head branch was pushed to by a user without write access
We don't have |
As we progress with a proposal, an author gets more clarity on the Type/Category. Changing either or both for a proposal before it is moved to There is a general agreement on adding RIP as a Standard Track Category discussed in EIPIP Meeting 95. We were hoping to have the PR to EIP-1 coming in by RIP working group. But, it can be made by anyone. |
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
This comment was marked as spam.
This comment was marked as spam.
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
As an artifact of the new RIP process, EIP-7212 has been converted from an EIP to an RIP. As RIP-7212 has already been created and there are no EIPs that depend on EIP-7212, it makes sense to just delete here to complete the move. CC @poojaranjan @ulerdogan