Skip to content

Update EIP-8030: Remove redundant .to_bytes() conversion in signature verification #10846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Update EIP-8030: Remove redundant .to_bytes() conversion in signature verification #10846

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion EIPS/eip-8030.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
# This is defined in [P256Verify Function](#p256verify-function)
assert(P256Verify(payload_hash, r, s, x, y) == Bytes("0x0000000000000000000000000000000000000000000000000000000000000001"))

return x.to_bytes(32, "big") + y.to_bytes(32, "big")
return x + y
```


Expand All @@ -71,7 +71,7 @@
## Security Considerations

Needs discussion.
<!-- TODO -->

Check warning on line 74 in EIPS/eip-8030.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

HTML comments are only allowed while `status` is one of: `Draft`, `Withdrawn` 

warning[markdown-html-comments]: HTML comments are only allowed while `status` is one of: `Draft`, `Withdrawn`
  --> EIPS/eip-8030.md
   |
74 | <!-- TODO -->
   |
   = help: see https://ethereum.github.io/eipw/markdown-html-comments/

Check warning on line 74 in EIPS/eip-8030.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

HTML comments are only allowed while `status` is one of: `Draft`, `Withdrawn` 

warning[markdown-html-comments]: HTML comments are only allowed while `status` is one of: `Draft`, `Withdrawn`
  --> EIPS/eip-8030.md
   |
74 | <!-- TODO -->
   |
   = help: see https://ethereum.github.io/eipw/markdown-html-comments/

## Copyright

Expand Down
Loading