Skip to content

Update EIP-7612: fix basicdata version byte to ensure 32-byte header #10832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Update EIP-7612: fix basicdata version byte to ensure 32-byte header #10832

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion EIPS/eip-7612.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
# Write an account in the verkle tree
def verkle_set_account(tree: VerkleTree, key: Bytes32, account: Optional[Account]):
if account is not None:
basicdata = bytes(0) # Version
basicdata = b'\x00' # Version
basicdata += bytes(4) # Reserved
basicdata += len(account.code).to_bytes(3, 'big')
basicdata += account.nonce.to_bytes(8, 'big')
Expand Down Expand Up @@ -155,7 +155,7 @@

## Test Cases

<!--

Check warning on line 158 in EIPS/eip-7612.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

HTML comments are only allowed while `status` is one of: `Draft`, `Withdrawn` 

warning[markdown-html-comments]: HTML comments are only allowed while `status` is one of: `Draft`, `Withdrawn`
   --> EIPS/eip-7612.md
    |
158 | <!--
    |
   ::: EIPS/eip-7612.md
    |
173 | <!--
    |
    = help: see https://ethereum.github.io/eipw/markdown-html-comments/
This section is optional for non-Core EIPs.

The Test Cases section should include expected input/output pairs, but may include a succinct set of executable tests. It should not include project build files. No new requirements may be introduced here (meaning an implementation following only the Specification section should pass all tests here.)
Expand Down