chain config: move 'optimism' to 'genesis.fee_params' #975
Conversation
bitwiseguy
force-pushed
the
ss/refactor-config-genesis-section
branch
from
1640f9a to
c9fdbb2
Compare
bitwiseguy
force-pushed
the
ss/refactor-config-genesis-section
branch
from
8a4dbcf to
79b30ac
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #975 +/- ##
==========================================
+ Coverage 41.92% 41.93% +0.01%
==========================================
Files 40 40
Lines 2674 2673 -1
==========================================
Hits 1121 1121
+ Misses 1450 1449 -1
Partials 103 103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| BaseFeeScalar *uint64 `json:"baseFeeScalar,omitempty" toml:"baseFeeScalar,omitempty"` | ||
| BlobBaseFeeScalar *uint64 `json:"blobBaseFeeScalar,omitempty" toml:"blobBaseFeeScalar,omitempty"` | ||
| BatcherAddr ChecksummedAddress `json:"batcherAddr" toml:"batcherAddress"` | ||
| BatchInboxAddr *ChecksummedAddress `json:"batchInboxAddr" toml:"batch_inbox_addr"` |
There was a problem hiding this comment.
This is an interesting one. The batch inbox address isn't actually in the system config that gets derived, just the contract.
The genesis system config vars, in my head, are things that can change (that the protocol supports changing in normal operation) - imo, it's fine to lift into genesis, but not genesis.system_config.
There was a problem hiding this comment.
Ahh ok got it. Will lift it one level to genesis then. And will update the op-geth and monorepo prs accordingly
There was a problem hiding this comment.
Maybe the inconsistency is that we would put this address that can be read from the system config (and that cannot be changed) into genesis.SystemConfig, but would still leave others in the addresses section. So @clabby @bitwiseguy wdyt about putting the batch inbox address into the addresses section instead?
Overview
Makes the following changes to the chain config .toml struct:
batch_inbox_addrfield moved from top level to[genesis.system_config][optimism]struct renamed/moved to [genesis.fee_params]Related Issues
Closes #969