-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unichain Sepolia L1 Pectra Upgrade with NEW Prestate #746
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick first review, I haven't gotten in depth yet, but there's a few things that need to be updated before we put this in front of EVM Safety
@@ -470,6 +475,14 @@ workflows: | |||
context: | |||
- circleci-repo-readonly-authenticated-github-token | |||
|
|||
- simulate_sequence: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is supposed to go into the sepolia sequence
@@ -0,0 +1,47 @@ | |||
# Unichain Sepolia L1 Petra Support Upgrade | |||
|
|||
Status: [EXECUTED](https://sepolia.etherscan.io/tx/0x7db018215e3af49fb2ad685eadf18e69d50903bfb13485a730648e4d5990a2b0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update to ready to sign and remove this tx hash
Registry links provided. This validates the bytecode deployed at the addresses contains the correct logic. | ||
- All key values match the semantic meaning provided, which can be validated using the storage layout links provided. | ||
|
||
## Expected Domain and Message Hashes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't checked yet, but can you make sure these are the hashes that correspond to this task
|
||
* Updates the `DisputeGameFactory` to point to the new `FaultDisputeGame` and `PermissionedDisputeGame` contracts by calling `DisputeGameFactory.setImplementation` | ||
|
||
See the [overview](./OVERVIEW.md) and `input.json` bundle for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like this overview file is present in this PR
Description
Tests
Additional context
Metadata