Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unichain Sepolia L1 Pectra Upgrade with NEW Prestate #746

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

winnsterx
Copy link
Contributor

Description

Tests

Additional context

Metadata

@winnsterx winnsterx requested review from a team as code owners March 11, 2025 23:56
@winnsterx winnsterx requested a review from tynes March 11, 2025 23:56
Copy link
Contributor

@sbvegan sbvegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick first review, I haven't gotten in depth yet, but there's a few things that need to be updated before we put this in front of EVM Safety

@@ -470,6 +475,14 @@ workflows:
context:
- circleci-repo-readonly-authenticated-github-token

- simulate_sequence:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is supposed to go into the sepolia sequence

@@ -0,0 +1,47 @@
# Unichain Sepolia L1 Petra Support Upgrade

Status: [EXECUTED](https://sepolia.etherscan.io/tx/0x7db018215e3af49fb2ad685eadf18e69d50903bfb13485a730648e4d5990a2b0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update to ready to sign and remove this tx hash

Registry links provided. This validates the bytecode deployed at the addresses contains the correct logic.
- All key values match the semantic meaning provided, which can be validated using the storage layout links provided.

## Expected Domain and Message Hashes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked yet, but can you make sure these are the hashes that correspond to this task


* Updates the `DisputeGameFactory` to point to the new `FaultDisputeGame` and `PermissionedDisputeGame` contracts by calling `DisputeGameFactory.setImplementation`

See the [overview](./OVERVIEW.md) and `input.json` bundle for more details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like this overview file is present in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants