Fix: Block number Returned is Not Integer. #737
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mds1
approved these changes
Mar 11, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix an minor issue that has been introduced two year ago that making the node always returning healthy even if it's not healthy.
Now instead of returning the full JSON we only return the block number.
tests
I tested this inside
anvilto make sure this is expected.$ ./ops/verify-geth-endpoint.sh http://localhost:8545 response: {"jsonrpc":"2.0","id":1,"result":false} Replica is not syncing. response: {"jsonrpc":"2.0","id":1,"result":"0x0"} block: 0 Block height is 0.