Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unichain Mainnet Petra L1 Upgrade #713

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Unichain Mainnet Petra L1 Upgrade #713

wants to merge 23 commits into from
+838 −2

Conversation

winnsterx
Copy link
Contributor

Description

Tests

Additional context

Metadata

@winnsterx winnsterx requested a review from a team as a code owner March 4, 2025 20:38
@maurelian maurelian self-assigned this Mar 4, 2025
Ethnical
Ethnical reviewed Mar 5, 2025
View reviewed changes
@Ethnical
Copy link
Contributor

Ethnical commented Mar 5, 2025 •
edited
Loading

The simulation is correct with the validation file.
however, some information are missing such as the:

  • State override
  • SC/Chain-governor livenessGuard

Once this is cleaned, I will merge this one.
And we should be ready for the signing window :)
CleanShot 2025-03-05 at 15 35 40@2x

@Ethnical
Copy link
Contributor

Ethnical commented Mar 5, 2025

We should point to this file called nested-validation that contain the state_override + safe nonce execution.

https://github.com/ethereum-optimism/superchain-ops/blob/8cc7a1e50dd38731880c65a3209f7326016ab322/NESTED-VALIDATION.md
The file does have the Unichain logic like the address etc.
So we MUST add it for unichain.
@winnsterx I will be on call for the next 30m after I can do that.

@Ethnical
Copy link
Contributor

Ethnical commented Mar 5, 2025 •
edited
Loading

Looks perfect ready to merge this one thanks @winnsterx 🔥
we just need to wait for the end of previous task #625 for the ci to pass :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ethnical Ethnical Ethnical left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@maurelian maurelian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@winnsterx @Ethnical @maurelian