fix: Fix bash script output in verify-geth-endpoint.sh #710
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes a potential issue in the verify-geth-endpoint.sh script by adding double quotes around the arithmetic expansion when outputting the block number. This change follows bash scripting best practices and prevents potential issues when handling special characters or spaces in variable values.
The specific change is in the get_current_block() function, where:
echo $((16#$trimmed_hex))
was changed to:
echo "$((16#$trimmed_hex))"
Tests
The script functionality remains unchanged, but is now more robust. The script was manually tested to ensure it continues to work as expected with the added quotes.
Additional context
This is a minor fix that follows shell scripting best practices. While the specific issue might not manifest in this particular case (as arithmetic expansions typically don't contain spaces), it's good practice to quote variable expansions in bash to prevent word splitting and globbing.
Metadata
Fixes #N/A (No specific issue was referenced for this change)