-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sepolia OPCM v2.0.0: op, soneium, ink #709
base: main
Are you sure you want to change the base?
Conversation
91eb264
to
aa1962a
Compare
00361c9
to
b621b8c
Compare
e78dbde
to
ccb45b9
Compare
5a7284e
to
bedc930
Compare
string memory expectedErrors_1946 = | ||
"SYSCON-20,PDDG-50,PDDG-DWETH-30,PDDG-DWETH-40,PDDG-ANCHORP-40,PDDG-120,PLDG-10"; | ||
string memory expectedErrors_763373 = | ||
"SYSCON-20,PDDG-50,PDDG-DWETH-30,PDDG-DWETH-40,PDDG-ANCHORP-40,PLDG-50,PLDG-DWETH-30,PLDG-DWETH-40,PLDG-ANCHORP-40"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maurelian can you check if these are ok too? This is for ink sepolia.
02cca5b
to
1a16781
Compare
b597832
to
3b9bddb
Compare
@@ -0,0 +1,706 @@ | |||
## Understanding Task Calldata | |||
|
|||
Multicall3DelegateCall calldata: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will this be validated? Can signers just copy it and ctrl+f for this string in the tenderly sim?
We should also include the target address for Multicall3DelegateCall
as that must not change.
I'm out of time now, but in the morning I'll generate a quick script to compute the calldata directly from a config to facilitate this review.
{absolutePrestate = "0x035ac388b5cb22acf52a2063cfde108d09b1888655d21f02f595f9c3ea6cbdcd", chainId = 11155420}, | ||
{absolutePrestate = "0x035ac388b5cb22acf52a2063cfde108d09b1888655d21f02f595f9c3ea6cbdcd", chainId = 1946}, | ||
{absolutePrestate = "0x035ac388b5cb22acf52a2063cfde108d09b1888655d21f02f595f9c3ea6cbdcd", chainId = 763373} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these will unfortunately need to change.
1772884
to
c4e14d3
Compare
6ffbec3
to
b499854
Compare
c4fbc57
to
ea592b4
Compare
8177326
to
34c1129
Compare
ea592b4
to
f0d71d6
Compare
34c1129
to
99d5472
Compare
f0d71d6
to
6cb2305
Compare
99d5472
to
6f93442
Compare
705248d
to
b10a724
Compare
6f93442
to
3ce45e2
Compare
b10a724
to
822f4d4
Compare
3ce45e2
to
9943b6f
Compare
822f4d4
to
a8da7f0
Compare
9943b6f
to
def6e04
Compare
a8da7f0
to
9d0bf43
Compare
3024c09
to
528fa58
Compare
b040464
to
91287ff
Compare
ddd342c
to
b99c96d
Compare
b99c96d
to
0115e40
Compare
0115e40
to
beecdce
Compare
This PR adds the Sepolia task for OP Sepolia, Soneium and Ink. All of which share the same L1 proxy admin owner key:
0x1Eb2fFc903729a0F03966B917003800b145F56E2
.You'll find the VALIDATION.md file in this PR which was generated by taking the state diff printed by our new superchain-ops code then cross referencing with the tenderly state diff.