fix: _isValidAction bug - only record top level call access kind #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered this issue when I was trying to make a delegatecall from within a
_build()function in a template. If the delegatecall contains calls inside the top level delegate call, then they incorrectly get added as a valid action. I do not believe this is intended behavior.Would be good to get @prat-gpt to review as I know you wrote this logic originally.
I was wondering "why don't non-top level calls get included in valid actions right now?". I believe the reason they don't is because of the line
bool accessorIsParent = (access.accessor == parentMultisig);in_isValidAction.