Use stdToml where possible, custom functions elsewhere #700
+18
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a suggestion from @mds1 about using
stdToml
instead of the more rawparseToml
commands.I took a stab at it. In the current repo, we would use
stdToml
exactly twice, because most of the time we are parsing structs thatstdToml
can't manage.We could extract the struct-reading abi.decode command into its own function. Some of them would be reusable such as
AddressesRegistry.readChainsFromToml
in this PR. Most of them would be template-specific.@mds1, worth it to fix the other templates in the same way as
TransferOwnerTemplate
here, or should we let it be?