-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aegir betanet upgrade task #581
Open
maurelian
wants to merge
8
commits into
main
Choose a base branch
from
aegir-opcm-upgrade
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+120
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d1550d
to
17ec49e
Compare
17ec49e
to
3bfbc7d
Compare
maurelian
commented
Feb 11, 2025
maurelian
commented
Feb 11, 2025
e5d87bf
to
072a2bd
Compare
maurelian
commented
Feb 11, 2025
mds1
reviewed
Feb 11, 2025
Comment on lines
+49
to
+52
This upgrade | ||
* Changes dispute game implementation of the `CANNON` and `PERMISSIONED_CANNON` game types to contain a `op-program` release for the Holocene hardfork, which contains | ||
the Holocene fork implementation as well as a `ChainConfig` and `RollupConfig` for the L2 chain being upgraded. | ||
* Upgrades `MIPS.sol` to support the `F_GETFD` syscall, required by the golang 1.22+ runtime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is out of date
mds1
reviewed
Feb 11, 2025
// For the purpose of the Aegir betanet upgrade, we will skip this check, as it will | ||
// require allowing a very large number of state accesses, across multiple chains. | ||
// checkStateDiff(accesses); | ||
console.log("All assertions passed!"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should run the standard validator checks here ethereum-optimism/optimism#14325
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a task for upgrading the Aegir betanet.
This build on #570 in order to minimize the diff in the submodule update.